Personally I don't have any way to test this change even though there's been a lot of chatter about it. Does anyone else have a way to validate this and/or merge it in?

A simple way to test this is to try to use @UnitOfWork with Hibernate sessions in authenticators. Authentification is now performed outside of Jersey lifecycle for security reasons, so the process should fail without a proxy.

@harshil07, @paukiatwee, @dotCipher, @yiweig, @vvondra can anyone confirm if this PR resolves your issue?

Happy to test @jplock but I'm not entirely sure on how to build the module for java 8.

This PR is against the 0.9 branch, which still uses Java 7. Something like this should work, though.

git checkout -b arteam-generalize_unit_of_work release/0.9.x
git pull https://github.com/arteam/dropwizard.git generalize_unit_of_work
cd ./dropwizard-bom
mvn install
cd ../
mvn install -DskipTests=true -P dev

@jplock In the end, since I use dropwizard-guice, I went with a simple proxy using https://github.com/google/guice/wiki/AOP or I actually inject a TransactionProvider class which has a method I can pass a callback to which will be executed transactionally

I tested this PR and it is working! Passed all my tests. My app at Github.

Set up

TokenAuthenticator tokenAuthenticator = new UnitOfWorkAwareProxyFactory(hibernate).create(TokenAuthenticator.class, FinanceService.class, financeService);
// auth
final OAuthCredentialAuthFilter<User> authFilter =
        new OAuthCredentialAuthFilter.Builder<User>()
                .setAuthenticator(tokenAuthenticator)
                .setPrefix("Bearer")
                .setAuthorizer(new DefaultAuthorizer())
                .setUnauthorizedHandler(new DefaultUnauthorizedHandler())
                .buildAuthFilter();

Authenticator

public class TokenAuthenticator implements Authenticator<String, User> {

    private final FinanceService financeService;

    public TokenAuthenticator(FinanceService financeService) {
        this.financeService = financeService;
    }

    @UnitOfWork
    @Override
    public Optional<User> authenticate(String token) throws AuthenticationException {
        java.util.Optional<User> option = financeService.findUserByToken(token);
        if(option.isPresent()) {
            return Optional.of(option.get());
        } else {
            return Optional.absent();
        }
    }
}

Previously financeService.findUserByToken(token) will throw error.

Excellent! Thank you for confirming @paukiatwee.

@arteam are you going to cherry pick this into master as well for 1.0.0?

Yes, will do.

Commits 39a857d and 0a5534e are cherry-picked to the master branch.

@dropwizard/committers, what do you think about releasing 0.9.2 with this workaround?

+1 from me

+1

Thanks & Regards
Shashank Harwalkar

On Tue, Jan 12, 2016 at 10:19 PM, Justin Plock notifications@github.com
wrote:

+1 from me

—
Reply to this email directly or view it on GitHub
#1361 (comment)
.

+1