Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange Cucumber and add some flair. #4347

Merged
merged 1 commit into from Jan 11, 2016

Conversation

envygeeks
Copy link
Contributor

  • Move step_definitions/jekyll.rb to just step_definitions.rb
  • Rename the formatter to Jekyll::Cucumber::Formatter, it's Jekyll's.
  • Add some flair; switch to checks!
  • Rename env.rb to helpers.rb

  • The renaming of env.rb to helpers.rb facilitates what it actually does and hints at people contributing as to what it does and where to place stuff if they are inside of Cucumber.
  • The moving of step_definitions is because it removes a single file folder.
  • The flair is just because.

* Move step_definitions/jekyll.rb to just step_definitions.rb
* Rename the formatter to Jekyll::Cucumber::Formatter, it's Jekyll's.
* Add some flair; switch to checks!
* Rename env.rb to helpers.rb
@parkr
Copy link
Member

parkr commented Jan 11, 2016

@jekyllbot: merge +dev

jekyllbot added a commit that referenced this pull request Jan 11, 2016
@jekyllbot jekyllbot merged commit 4dccb00 into master Jan 11, 2016
@jekyllbot jekyllbot deleted the rearrange-cucumber-add-flair branch January 11, 2016 21:10
jekyllbot added a commit that referenced this pull request Jan 11, 2016
@mattr-
Copy link
Member

mattr- commented Jan 11, 2016

I'm surprised cucumber doesn't break without a step_definitions folder.

@parkr
Copy link
Member

parkr commented Jan 11, 2016

@mattr- shrug

@envygeeks
Copy link
Contributor Author

@mattr- I was surprised too, I was adding Cucumber to an app I was building and said "man this single folder file is ugly" so I tried it and it worked so I was like YAY for organization.

@pathawks pathawks mentioned this pull request May 24, 2016
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants