Move Cucumber to using RSpec-Expections and furthering JRuby support. #4343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
envygeeks
commented
Jan 10, 2016
envygeeks
commented
- Removes posix-spawn in favor of Open3#popen3
- Encapsulates all the paths into a single easy class.
- Moves to %r{} to avoid ambiguious warnings per-Cucumber suggestion.
- Starts passing around Pathname to make some actions faster.
- Clean's up some methods to make them easier to read.
- AUTOMATIC: Add "#" between each method.
* Removes posix-spawn in favor of Open3#popen3
* Encapsulates all the paths into a single easy class.
* Moves to %r{} to avoid ambiguious warnings per-Cucumber suggestion.
* Starts passing around Pathname to make some actions faster.
* Clean's up some methods to make them easier to read.
* AUTOMATIC: Add "#" between each method.
envygeeks
force-pushed
the
pr/cucumber-rspec-expec-jruby-support
branch
from
4f9bbe1
to
3c9f159
Compare
|
@envygeeks Is this ready for review now that CI is green? |
|
@parkr yessum. |
|
LGTM! @jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Jan 11, 2016
…pport Merge pull request 4343
jekyllbot
added a commit
that referenced
this pull request
Jan 11, 2016
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.