Drops should use content setters if they exist #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
force-pushed
the
fix-layout-metadata
branch
from
e1a4141
to
95a3c54
Compare
|
Thank you, I have added this change, but it does not fix my issue. |
| --- | ||
| foo: my custom data | ||
| --- | ||
| {{ content }} foo: {{ layout.foo }} |
There was a problem hiding this comment.
In my case I was doing {{ layout.foo }} from parent layout file index.html, not from custom.html.
There was a problem hiding this comment.
See a9b80b2 for this. It works on master according to my scenario.
parkr
added a commit
that referenced
this pull request
Jan 5, 2016
|
Yes, you are right, @parkr, thank you. I needed to install jekyll from master to make it work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@evgenyneu, this fixes your issue as defined here: #4246 (comment)