Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For blessed gems, shim their commands so users know how to use them. #4254

Merged
merged 2 commits into from Jan 5, 2016
Merged

For blessed gems, shim their commands so users know how to use them. #4254

merged 2 commits into from Jan 5, 2016

Conversation

parkr
Copy link
Member

@parkr parkr commented Dec 11, 2015

Basically doing #4253 but for Jekyll 3.

@parkr parkr added this to the 3.1 milestone Dec 11, 2015
@envygeeks
Copy link
Contributor

What if we did this for all gems instead of through commands? If Jane adds gem: jekyll-this-gem then we throw with the message: "unable to require jekyll-this-gem" have you installed `"jekyll-this-gem"? Most of the time we can infer what the gem name is reliably from the require.

@parkr
Copy link
Member Author

parkr commented Dec 24, 2015

If Jane adds gem: jekyll-this-gem then we throw with the message: "unable to require jekyll-this-gem" have you installed `"jekyll-this-gem"?

Yes, we do! Anywhere we use Jekyll::External.require_with_graceful_fail, we are doing that. This PR is for subcommands.

@parkr parkr force-pushed the shim-docs-import-with-nudge branch from 31b0e88 to d37de5c Compare January 5, 2016 00:17
parkr added a commit that referenced this pull request Jan 5, 2016
@parkr
Merge pull request #4254 from jekyll/shim-docs-import-with-nudge
f995d86 
Merge pull request 4254
@parkr parkr merged commit f995d86 into master Jan 5, 2016
@parkr parkr deleted the shim-docs-import-with-nudge branch January 5, 2016 00:30
parkr added a commit that referenced this pull request Jan 5, 2016
@parkr
Update history to reflect merge of #4254
935e556 
[ci skip]
@jekyll jekyll locked and limited conversation to collaborators Feb 27, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
frozen-due-to-age plugin-feature
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@parkr @envygeeks @jekyllbot