Remove Fedora 21 from RPM build as it is EOL #18794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -22,7 +22,7 @@ for version in "${versions[@]}"; do | |||
| suite="${version##*-}" | |||
| from="${distro}:${suite}" | |||
| installer=yum | |||
| if [[ "$distro" == "fedora" ]] && [[ "$suite" -ge "22" ]]; then | |||
| if [[ "$distro" == "fedora" ]]; then | |||
There was a problem hiding this comment.
not sure if all current CentOS and RHEL releases also have dnf installed by default now
There was a problem hiding this comment.
ya centos does not but this LGTM awesome!
There was a problem hiding this comment.
yeah, we can tweak later, just was wondering when I saw this, haha
|
ping @jfrazelle @tianon |
|
LGTM |
|
Also see this PR #18790, which can be merged if this accepted :) |
| @@ -11,7 +11,7 @@ weight=-3 | |||
|
|
|||
| # Fedora | |||
|
|
|||
| Docker is supported Fedora version 21 and 22. This page instructs you to install | |||
| Docker is supported Fedora version 22 and 23. This page instructs you to install | |||
There was a problem hiding this comment.
oh, see that this misses "on". let me fix that as well
Fedora 21 is EOL'd as of December 1st, 2015. Announcement: https://lists.fedoraproject.org/pipermail/announce/2015-November/003296.html Fedora 21 will reach end of life on 2015-12-01, and no further updates will be pushed out after that time. Additionally, with the recent release of Fedora 23, no new packages will be added to the Fedora 21 collection. Please see https://fedoraproject.org/wiki/DNF_system_upgrade for more information on upgrading from Fedora 21 to a newer release. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
EOL-fedora-21
branch
from
4bf5bbc
to
a08c955
Compare
|
LGTM |
runcom
added a commit
that referenced
this pull request
Dec 20, 2015
Remove Fedora 21 from RPM build as it is EOL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fedora 21 is EOL'd as of December 1st, 2015, so we should not publish RPMs for Docker 1.10
Announcement:
https://lists.fedoraproject.org/pipermail/announce/2015-November/003296.html