Deprecate HostConfig at API container start #17799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unluckily, adding a deprecation notice in API response requires modifying the returned status code or add content to a 204 no-content response. I hope the deprecation notice here will suffice. |
| @@ -12,6 +12,14 @@ parent = "mn_use_docker" | |||
|
|
|||
| The following list of features are deprecated. | |||
|
|
|||
| ### HostConfig at API container start | |||
| **Deprecated In Release: v1.9** | |||
There was a problem hiding this comment.
hm, don't think we can add this, now that 1.9 was released? @tiborvass wdyt?
There was a problem hiding this comment.
Right, just copy pasted, it should be 1.10
runcom
force-pushed
the
deprecate-hc-cont-start
branch
from
4f726ae
to
32e1d9e
Compare
|
LGTM |
|
ping @cpuguy83 does this LGTY? |
|
LGTM ping @vieux @aluzzardi |
runcom
force-pushed
the
deprecate-hc-cont-start
branch
from
32e1d9e
to
bebb2e1
Compare
Signed-off-by: Antonio Murdaca <runcom@redhat.com>
runcom
force-pushed
the
deprecate-hc-cont-start
branch
from
bebb2e1
to
3e7405a
Compare
|
rebased! |
|
LGTM |
calavera
added a commit
that referenced
this pull request
Nov 25, 2015
Deprecate HostConfig at API container start
|
👍 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antonio Murdaca runcom@redhat.com