Allow syslog over TCP+TLS. #18998
Allow syslog over TCP+TLS. #18998
Conversation
calavera
force-pushed
the
syslog_tls
branch
2 times, most recently
from
b60465c
to
d0f14e4
Compare
|
Thanks @calavera! |
|
This is blocked by RackSec/srslog#5. |
|
Should we close this in the meantime? |
no need, it was just merged. I'm updating the vendor. |
calavera
force-pushed
the
syslog_tls
branch
2 times, most recently
from
37c01d8
to
bed6eac
Compare
|
LGTM |
1 similar comment
|
LGTM |
cpuguy83
added
status/4-merge
status/2-code-review
and removed
status/2-code-review
status/4-merge
labels
|
Actually, can you split the vendor into a separate commit? |
|
also needs a a rebase :( |
The syslog package in the stdlib is not maintained anymore. Signed-off-by: David Calavera <david.calavera@gmail.com>
|
LGTM |
1 similar comment
|
LGTM |
calavera
added
impact/changelog
impact/cli
status/2-code-review
status/3-docs-review
and removed
status/4-merge
status/2-code-review
labels
|
ping @thaJeztah @moxiegirl for review |
| @@ -107,6 +111,14 @@ the following named facilities: | |||
| * `local6` | |||
| * `local7` | |||
|
|
|||
| `syslog-tls-ca-cert` specifies the absolute path in the host to the Trust certs signed by the CA. This option is ignored if the address protocol is not `tcp+tls`. | |||
There was a problem hiding this comment.
minor nits;
s/Trust/trust/
s/certs/certificates/
also, can you wrap your lines to 80 chars?
There was a problem hiding this comment.
oh, and absolute path in the host -> on the host? (or simply "the absolute path")
|
Thanks @calavera; some minor nits |
Signed-off-by: David Calavera <david.calavera@gmail.com>
|
@thaJeztah I addressed your comments. |
|
docs LGTM 🐉 |
| @@ -107,6 +111,19 @@ the following named facilities: | |||
| * `local6` | |||
| * `local7` | |||
|
|
|||
| `syslog-tls-ca-cert` specifies the absolute path to the trust certificates | |||
There was a problem hiding this comment.
Maybe form each of these into proper sentences:
The syslog-tls-ca-cert options specifies ....
|
Docs LGTM minor comment. |
|
@jamtur01 agreed, it can use a touch-up; I compared it to the existing docs, and decided that it's probably better to do that in a separate PR. Thanks for helping out reviewing James, much appreciated!! LGTM I'll merge this; we can revisit in e separate PR |
Replace Go's stdlib version because it's no longer maintained.
Fixes #18364
Signed-off-by: David Calavera david.calavera@gmail.com