Fix race causing autorestart turning off on restart #17629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it need to be an Error log? |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
kill-autorestart-fix
branch
from
ee0d017
to
b8aaa4b
Compare
|
@cpuguy83 Changed to warn. Its good to log this because its very unlikely to appear, meaning if you see this in the logs you had some quite weird containers running. |
|
LGTM |
1 similar comment
|
LGTM |
calavera
added a commit
that referenced
this pull request
Nov 3, 2015
Fix race causing autorestart turning off on restart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When application takes a long time to handle
SIGTERMthere can be a race between application closing by itself and docker callingcontainer.Kill(). If application closes first,Kill()will error because container is already stopped. This will also mean thatdocker restartwill error after container is stopped and restart policies will not try to restart it.cc @crosbymichael @andrewnguyen
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com