Skip to content
This repository has been archived by the owner on Nov 16, 2020. It is now read-only.

Introduce a new custom header containing the timestamp when message was shoveled #2

Closed
c-datculescu opened this issue Jun 3, 2015 · 6 comments
Assignees
Milestone

Comments

@c-datculescu
Copy link

Hello.

I would like to propose introducing a new header that should contain the timestamp when message was shovelled. The current headers are already very good in identifying the origin of message among other things, but i think the timestamp would be useful as well.

Thank you,
Cristian.

@michaelklishin michaelklishin added this to the 3.6.0 milestone Jun 3, 2015
@michaelklishin
Copy link
Member

Sounds reasonable, also easy to do.

@Zteve
Copy link
Contributor

Zteve commented Jun 3, 2015

I suggest the timestamp, if present, should record when the message was last shovelled, and include some indication of the shovel that put this there.

Should this feature be an optional feature of the shovel (default no timestamp)? I was under the impression that the general assumption was that shovels don't modify the messages they 'shovel' about.

@c-datculescu
Copy link
Author

Hello.

From the use case i have i think it would be reasonable to make it optional, but i am fine with both options.

Thank you for taking this into consideration.

@hairyhum
Copy link
Contributor

hairyhum commented Jan 7, 2016

Should it be separate header, or maybe it's better be included in x-shovelled, since it's already a list of parameters there?

@michaelklishin
Copy link
Member

including into the existing is fine but will be slightly
more involved to implement in a backwards compatible way. I trust your judgement:)

On 7 ene 2016, at 14:10, Daniil Fedotov notifications@github.com wrote:

Should it be separate header, or maybe it's better be included in x-shovelled, since it's already a list of parameters there?


Reply to this email directly or view it on GitHub.

@hairyhum
Copy link
Contributor

New header will be easier to configure (and to implement).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants