Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Move from Webmachine to Cowboy #63

Closed
21 tasks done
essen opened this issue Sep 15, 2015 · 5 comments
Closed
21 tasks done

Move from Webmachine to Cowboy #63

essen opened this issue Sep 15, 2015 · 5 comments
Assignees
Milestone

Comments

@essen
Copy link
Collaborator

essen commented Sep 15, 2015

It's a fairly large task involving more than a handful of applications, including management, web-dispatch, web-stomp-examples and many applications depending on management. I will try to maintain the API (and so avoid making changes in these many applications) but they will need to at least be tested to confirm everything works as intended.

The community plugins found at https://www.rabbitmq.com/community-plugins.html should also be checked. Since Webmachine is being removed, there's no other choice than breaking things (plugins include a header from Webmachine), but hopefully that break will be only constrained to resources and will be easy to document and fix.

  • management: port definitions resource multipart handling code to Cowboy
    • curl -i http://guest:guest@localhost:15672/api/definitions -X POST -H "content-type: multipart/form-data;boundary=abcdef"
  • management: git grep wrq
  • management: git grep -i webmachine
  • management: play around in the UI
  • management: tests
  • web dispatch: tests
  • management: add / -> /index.html routes
  • management: add redirects for API etc.
  • management: access logs
  • management: fix crashes found in logs during (successful) tests
  • management: support both IPv4 and IPv6 (Dual IP stack support #64)
  • management: last clean up, check warnings, unused functions, Dialyzer
  • web dispatch: git grep -i webmachine
  • web dispatch: git grep Req:
  • web dispatch: test with SSL
  • web dispatch: error handler
  • web dispatch: update plugins that use web dispatch
  • web dispatch: last clean up, check warnings unused functions, Dialyzer
  • web dispatch: update README
  • web stomp: make sure examples still work
  • update documentation
@essen
Copy link
Collaborator Author

essen commented Oct 2, 2015

Spent 3 days on this so far. It's still a work in progress and here is a list of things I still need to look at:

EDIT: (task list moved to original post)

Everything I tried in the UI works as far as I can see, but I didn't try everything and I know some things are not working yet. I suspect this needs about 3 days of additional work to get it to completion.

@michaelklishin
Copy link
Member

Thank you, Loïc.

We have at least 2 fairly well covered client libraries for the HTTP API to help with testing.

On 2 oct 2015, at 19:39, Loïc Hoguin notifications@github.com wrote:

Spent 3 days on this so far. It's still a work in progress and here is a lit of things I still need to look at:

git grep wrq:
git grep -i webmachine
make test (currently fails early)
add / -> /index.html routes
add the redirects that I left out for now
probably left a few warnings/unused functions for now for things that are not fully done
check ssl
check the plugins that depend on web dispatch and fix them as interface changed slightly
Everything I tried in the UI works as far as I can see, but I didn't try everything and I know some things are not working yet. I suspect this needs about 3 days of additional work to get it to completion.


Reply to this email directly or view it on GitHub.

@essen
Copy link
Collaborator Author

essen commented Dec 21, 2015

This is ready for review!

@michaelklishin
Copy link
Member

We need to decide if this can go into 3.6.x. Otherwise so far the changes look ready. I'll do some more testing of definitions export/import.

@michaelklishin
Copy link
Member

Merged into master only.

@michaelklishin michaelklishin added this to the 3.7.0 milestone Dec 29, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants