Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

*: Move to go 1.5. #1907

Merged
merged 5 commits into from Dec 23, 2015
Merged

*: Move to go 1.5. #1907

merged 5 commits into from Dec 23, 2015

Conversation

krnowak
Copy link
Collaborator

@krnowak krnowak commented Dec 21, 2015

At this point we drop support for go 1.4.

We still support go 1.4, but it is only used in travis. Semaphore builds with go 1.5 only now.

@jonboulle
Copy link
Contributor

I'm on the fence about dropping 1.4 support. How about waiting until 1.6 is out?

@@ -3,17 +3,13 @@
language: go

go:
- 1.4
- 1.5
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have to update to 1.5.2. I thought that this will fetch the latest go 1.5, but apparently it fetches the oldest one.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is annoying :<. We should really pin 1.4 too.

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 21, 2015

I'm on the fence about dropping 1.4 support. How about waiting until 1.6 is out?

Dunno, what would this support mean? Should we run tests in travis and semaphore with both go 1.4 and 1.5?

@jonboulle
Copy link
Contributor

Dunno, what would this support mean? Should we run tests in travis and semaphore with both go 1.4 and 1.5?

Basically, yes. For development, our releases, and CoreOS Linux, we'll use 1.5, but we continue providing best-effort support that master builds against 1.4

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 21, 2015

Basically, yes. For development, our releases, and CoreOS Linux, we'll use 1.5, but we continue providing best-effort support that master builds against 1.4

Uh, that would make semaphore tests from taking ages to complete to taking forever. How about we build rkt with both go versions in travis, but semaphore would build only with 1.5?

@jonboulle
Copy link
Contributor

OK

On Mon, Dec 21, 2015 at 2:52 PM, Krzesimir Nowak notifications@github.com
wrote:

Basically, yes. For development, our releases, and CoreOS Linux, we'll use
1.5, but we continue providing best-effort support that master builds
against 1.4

Uh, that would make semaphore tests from taking ages to complete to taking
forever. How about we build rkt with both go versions in travis, but
semaphore would build only with 1.5?


Reply to this email directly or view it on GitHub
#1907 (comment).

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 21, 2015

Boo, and I felt so good getting rid of this RKT_XF crap from configure.ac. ;) Alright, will rework it.

@jonboulle
Copy link
Contributor

sorry, it's my official role as Fun Suppressor™

On Mon, Dec 21, 2015 at 2:59 PM, Krzesimir Nowak notifications@github.com
wrote:

Boo, and I felt so good getting rid of this RKT_XF crap from configure.ac.
;) Alright, will rework it.


Reply to this email directly or view it on GitHub
#1907 (comment).

@krnowak krnowak force-pushed the krnowak/move-to-go-1-5 branch 2 times, most recently from 85f6cd5 to aec1d37 Compare December 21, 2015 16:47
marineam and others added 5 commits December 21, 2015 17:50
This was actually a case for some time already, but it wasn't coded in
configure. This also cleans up the awful regexes munged by autoconf.
@jellonek
Copy link
Contributor

@jonboulle nice one! :)
@krnowak would it be possible to run in parallel 2x semaphore, once per one go version? is it possible?

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 21, 2015

@krnowak would it be possible to run in parallel 2x semaphore, once per one go version? is it possible?

@jellonek See the discussion above about it - I didn't want to do it on semaphore, because the already long tests would now take forever to complete.

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 21, 2015

@jellonek The only way to keep times as they are now and run functional tests built with both version of go would be to buy some better plan on semaphore. But it is not up to me to decide about that.

@jellonek
Copy link
Contributor

ok, this was what I was asking about, two parallel separate jobs on semaphore.
but if golang 1.6 is planned for the end of January - imo there is no good reason why to do that...

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 21, 2015

ok, this was what I was asking about, two parallel separate jobs on semaphore.

We already are running two parallel jobs on semaphore - one is building some flavors and the other one the other flavors. We would need to actually have four jobs running in parallel.

@jonboulle
Copy link
Contributor

The plan is still to move away from semaphore to Jenkins, fwiw.

Krzesimir Nowak notifications@github.com schrieb am Mo., 21. Dez. 2015
18:28:

ok, this was what I was asking about, two parallel separate jobs on
semaphore.

We already are running two parallel jobs on semaphore - one is building
some flavors and the other one the other flavors. We would need to actually
have four jobs running in parallel.


Reply to this email directly or view it on GitHub
#1907 (comment).

@jonboulle
Copy link
Contributor

@krnowak is this good to go?

@krnowak
Copy link
Collaborator Author

krnowak commented Dec 23, 2015

@jonboulle: Yep. I mean - it is good to be reviewed. :)

@jonboulle
Copy link
Contributor

LGTM, thank you.

jonboulle added a commit that referenced this pull request Dec 23, 2015
@jonboulle jonboulle merged commit b88a60e into rkt:master Dec 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants