Conversation
I'm on the fence about dropping 1.4 support. How about waiting until 1.6 is out? |
@@ -3,17 +3,13 @@ | |||
language: go | |||
|
|||
go: | |||
- 1.4 | |||
- 1.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to update to 1.5.2
. I thought that this will fetch the latest go 1.5, but apparently it fetches the oldest one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this is annoying :<. We should really pin 1.4 too.
Dunno, what would this support mean? Should we run tests in travis and semaphore with both go 1.4 and 1.5? |
Basically, yes. For development, our releases, and CoreOS Linux, we'll use 1.5, but we continue providing best-effort support that master builds against 1.4 |
Uh, that would make semaphore tests from taking ages to complete to taking forever. How about we build rkt with both go versions in travis, but semaphore would build only with 1.5? |
OK On Mon, Dec 21, 2015 at 2:52 PM, Krzesimir Nowak notifications@github.com
|
Boo, and I felt so good getting rid of this RKT_XF crap from configure.ac. ;) Alright, will rework it. |
sorry, it's my official role as Fun Suppressor™ On Mon, Dec 21, 2015 at 2:59 PM, Krzesimir Nowak notifications@github.com
|
85f6cd5
to
aec1d37
Compare
This was actually a case for some time already, but it wasn't coded in configure. This also cleans up the awful regexes munged by autoconf.
aec1d37
to
d0bcb94
Compare
@jonboulle nice one! :) |
@jellonek The only way to keep times as they are now and run functional tests built with both version of go would be to buy some better plan on semaphore. But it is not up to me to decide about that. |
ok, this was what I was asking about, two parallel separate jobs on semaphore. |
We already are running two parallel jobs on semaphore - one is building some flavors and the other one the other flavors. We would need to actually have four jobs running in parallel. |
The plan is still to move away from semaphore to Jenkins, fwiw. Krzesimir Nowak notifications@github.com schrieb am Mo., 21. Dez. 2015
|
@krnowak is this good to go? |
@jonboulle: Yep. I mean - it is good to be reviewed. :) |
LGTM, thank you. |
At this point we drop support for go 1.4.We still support go 1.4, but it is only used in travis. Semaphore builds with go 1.5 only now.