Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't identify git version on Windows #2167

Closed
i00 opened this issue Dec 13, 2015 · 13 comments
Closed

Can't identify git version on Windows #2167

i00 opened this issue Dec 13, 2015 · 13 comments
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it
Milestone
0.9.0

Comments

@i00
Copy link

i00 commented Dec 13, 2015

0.7.33.1205 worked fine, but with 0.8 I cannot start it as I get:

.../gogs/models/repo.go:108 NewRepoContext()] [E] Gogs requires Git version greater or equal to 1.7.1

My git version is 2.6.3.windows.1
@unknwon
Copy link
Member

unknwon commented Dec 13, 2015

What is the output when you execute:

$ git version

@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 13, 2015
@unknwon unknwon added this to the 0.9.0 milestone Dec 13, 2015
@i00
Copy link
Author

i00 commented Dec 13, 2015

2.6.3.windows.1 is the output from git --version, this is the command on Windows... btw I am using the x64 version

@unknwon
Copy link
Member

unknwon commented Dec 13, 2015

Oh... I see, that is the problem.

Gogs only recognizes output format like git version 1.8.3.1.

@unknwon unknwon added 💊 bug Something isn't working and removed status: needs feedback Tell me more about it labels Dec 13, 2015
@unknwon unknwon changed the title Gogs incorrectly identifies Git Can't identify git version on Windows Dec 13, 2015
unknwon added a commit that referenced this issue Dec 13, 2015
@unknwon
#2167 able to identify git version on Windows
79dcd7e
@unknwon unknwon added the status: needs feedback Tell me more about it label Dec 13, 2015
@unknwon
Copy link
Member

unknwon commented Dec 13, 2015

Hi, I just pushed a fix to develop branch, please update dependency by go get -u github.com/gogits/git-shell as well.

@andreynering
Copy link
Contributor

I just tried the develop branch and had the same issue. I had to comment these lines and everything worked fine.

The output to git --version is:

git version 2.5.2.windows.2

@unknwon
Copy link
Member

unknwon commented Dec 14, 2015

Now someone is talking... I see the problem now

@unknwon
Copy link
Member

unknwon commented Dec 14, 2015

Hi @andreynering , can you go get -u github.com/gogits/git-shell again and test, thanks!

@andreynering
Copy link
Contributor

@unknwon It's fixed now.

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

@andreynering thanks your confirmation!

@unknwon
Copy link
Member

unknwon commented Dec 15, 2015

cc @i00

@i00
Copy link
Author

i00 commented Dec 15, 2015

Thanks 👍 ...

And not trying to sound impatient ... but when will this be in a release?

@unknwon
Copy link
Member

unknwon commented Dec 16, 2015

@i00 18th this month...so it will be Friday?

@unknwon
Copy link
Member

unknwon commented Dec 18, 2015

Close as fixed.

@unknwon unknwon closed this as completed Dec 18, 2015
ethantkoenig pushed a commit to ethantkoenig/gogs that referenced this issue Sep 16, 2017
@bit @lafriks
Only show "No Description" to repo admins (gogs#2167)
98c5a1e 
Only show note about missing description ("No Description") to repo admins, nobody else can change it.
richmahn referenced this issue in unfoldingWord/dcs Feb 5, 2019
@gabrielsimoes @zeripath
Revert #3711 overwrite of only show "No Description" to repo admins #…
5f4a40c 
…2167 (#5836)

Revert #3711 overwrite of only show "No Description" to repo admins  #2167 and add tests to prevent accidental overwrite again.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💊 bug Something isn't working status: needs feedback Tell me more about it
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
3 participants
@i00 @unknwon @andreynering