updateInDeepMap should use is() for final value equality #690
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that I was seeing a ton of changes when doing a
mergeDeepIn
and traced it down to the fact thatupdateDeepMap
not usingis
and thus ending up with every Date object causing a change. This fixes that, test included.Also I guess somewhere along the line an old version of
Immutable.d.ts
got checked in, so that's what all the noise is in the change diffs.