Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use require.resolve to get path to topojson files #48

Merged
merged 2 commits into from Dec 7, 2015
Merged

Use require.resolve to get path to topojson files #48

merged 2 commits into from Dec 7, 2015

Conversation

etpinard
Copy link
Contributor

@justinwoo @mdtusz @bpostlethwaite

I found a possibly cleaner way (you tell me 馃槃) to find the path to the topojson files using node's require.resolve.

Supports both npm@2 and npm@3 .

@etpinard
Copy link
Contributor Author

relevant PR: #12

@mdtusz
Copy link
Contributor

mdtusz commented Nov 30, 2015

Looks good to me! require.resolve uses the same logic as regular requires so it shouldn't encounter any issues with different node versions.

etpinard added a commit that referenced this pull request Dec 7, 2015
@etpinard
Merge pull request #48 from plotly/better-topojson
0bbfa25 
Use require.resolve to get path to topojson files
@etpinard etpinard merged commit 0bbfa25 into master Dec 7, 2015
@etpinard etpinard deleted the better-topojson branch December 7, 2015 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etpinard @mdtusz