also parse scientific notation as a double/decimal #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`BigDecimal` and `Double`'s `.toString` uses scientific notation when the number has more than 6 decimal points.
So, when you have a Jackson generated JSON payload, you may end up with something like
```
{"my-double": "3E-8"}
```
will fail with a NumberFormatException:
```
! java.lang.NumberFormatException: For input string: "3E-8"
! at java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
! at java.lang.Long.parseLong(Long.java:589)
! at java.lang.Long.parseLong(Long.java:631)
! at com.fasterxml.jackson.databind.util.TokenBuffer$Parser.getNumberValue(TokenBuffer.java:1392)
! at com.fasterxml.jackson.databind.util.TokenBuffer$Parser.getDoubleValue(TokenBuffer.java:1340)
! at com.fasterxml.jackson.databind.deser.std.UntypedObjectDeserializer.deserialize(UntypedObjectDeserializer.java:207)
! at com.fasterxml.jackson.databind.deser.std.MapDeserializer._readAndBindStringMap(MapDeserializer.java:430)
! at com.fasterxml.jackson.databind.deser.std.MapDeserializer.deserialize(MapDeserializer.java:312)
```
It's a bit of a corner case; for me, I was converting a class with a non-standard descendant of `Number` (`scala.math.BigDecimal`) into a `Map<String, Object>` and it only broke once I got smaller numbers.
Happy to write a unit test if that helps; I only didn't because I opened this from the github web UI.
|
Yes, I think you are right, detection of non-integer numbers is insufficient here, as scientific notation is indeed only allowed for floating point numbers in JSON (or rather, floating-point handling is needed with it). I think 'e' is also needed, but I can easily add that. A simple unit test would be welcome, if you have time; if not, I can merge add something myself. |
|
Actually, I can do additions on my own. |
cowtowncoder
added a commit
that referenced
this pull request
Jun 30, 2015
also parse scientific notation as a double/decimal
cowtowncoder
added a commit
that referenced
this pull request
Jun 30, 2015
|
cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BigDecimalandDouble's.toStringuses scientific notation when the number has more than 6 decimal points.So, when you have a Jackson generated JSON payload, you may end up with something like
will fail with a NumberFormatException:
It's a bit of a corner case; for me, I was converting a class with a non-standard descendant of
Number(scala.math.BigDecimal) into aMap<String, Object>and it only broke once I got smaller numbers.Happy to write a unit test if that helps; I only didn't because I opened this from the github web UI.