MESOS: don't attempt to schedule static pods #13943

jdef · 2015-09-14T23:05:26Z

TODO:

add static pod to mesos-docker cluster for testing
restructure static pod config/zipper code to be more amenable to munging
modify static pod configs to include the proper binding annotation
switch from zip archive to gzip'd api.PodList for static pods
write the host binding annotation in the executor, not the scheduler; clean up procurement!
unit tests
e2e test for static pods

was BLOCKED by:

MESOS: Add pod resource request support #17054 :: properly deal with resource request/limit during resource procurement

googlebot · 2015-09-14T23:05:27Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

jdef · 2015-09-14T23:07:33Z

contrib/mesos/pkg/scheduler/service/service.go

+		staticPodCPUs += float64(cpu)
+		staticPodMem += float64(mem)
+
+		// TODO(jdef) add binding annotation so that static pods aren't picked up by the scheduler


this is where we'd add the missing binding annotation

k8s-bot · 2015-09-14T23:43:54Z

GCE e2e build/test failed for commit 8d748482417f59c41ec1f20f690c9c1f71674963.

k8s-github-robot · 2015-09-15T00:02:16Z

Labelling this PR as size/L

k8s-bot · 2015-09-17T14:27:29Z

GCE e2e build/test passed for commit b24523b0f13f7d77cf17d5fe38c1b3909d4c0f9b.

jdef · 2015-09-17T15:11:38Z

@sttts why did you delete this branch?

sttts · 2015-09-17T15:20:44Z

Oops. Sorry. I thought that's the old static-pods implementation branch.

sttts · 2015-09-17T15:21:10Z

We should think about some branch naming scheme.

jdef · 2015-09-17T15:26:18Z

agreed. for example, if it's tied one of our k8sm issues, perhaps something
like k8sm-{issueId}-{shortName}

On Thu, Sep 17, 2015 at 11:21 AM, Dr. Stefan Schimanski <
notifications@github.com> wrote:

We should think about some branch naming scheme.

—
Reply to this email directly or view it on GitHub
#13943 (comment)
.

sttts · 2015-09-17T15:30:20Z

[k8sm-{issueid}]-{feature|cleanup|bug}-{shortName}

jdef · 2015-09-18T04:45:25Z

contrib/mesos/pkg/scheduler/service/service.go

 	"k8s.io/kubernetes/pkg/api/resource"
 	client "k8s.io/kubernetes/pkg/client/unversioned"
 	clientauth "k8s.io/kubernetes/pkg/client/unversioned/auth"
 	"k8s.io/kubernetes/pkg/master/ports"
 	etcdstorage "k8s.io/kubernetes/pkg/storage/etcd"
 	"k8s.io/kubernetes/pkg/tools"
+
+	// lock to this API version, compilation will fail when this becomes unsupported
+	_ "k8s.io/kubernetes/pkg/api/v1"


should probably invoke an empty/noop func in v1 to really force the compiler to pick up on this (endpoints controller used to do something similar with the old v1beta1, v1beta2)

k8s-bot · 2015-09-18T04:49:42Z

GCE e2e build/test passed for commit 22378430a65e627cec496c992fdd30d71174c9ef.

jdef · 2015-09-18T04:55:50Z

@sttts @s-urbaniak PTAL (yes, I still need to write unit tests)

k8s-bot · 2015-09-18T05:20:53Z

GCE e2e build/test passed for commit b5978f3341dd94e8c21d7d74ae24871d3cadbb8a.

k8s-github-robot · 2015-09-18T05:25:54Z

Labelling this PR as size/XL

sttts · 2015-09-18T08:04:55Z

cluster/mesos/docker/docker-compose.yml

@@ -158,6 +158,7 @@ scheduler:
    --mesos-master=mesosmaster1:5050
    --cluster-dns=10.10.10.10
    --cluster-domain=cluster.local
+    --static-pods-config=/static-pods


Before merging we should remove this commit again.

k8s-bot · 2015-11-13T21:56:41Z

GCE e2e build/test failed for commit e08e4564df0371bf6c113f2799d1c95f4ce15b80.

k8s-bot · 2015-11-13T22:39:25Z

GCE e2e build/test failed for commit 2429fb2da3450d24731bc972deb55fb09332277c.

googlebot · 2015-11-13T23:27:07Z

CLAs look good, thanks!

googlebot · 2015-11-13T23:28:56Z

CLAs look good, thanks!

- add busybox static pod to mesos-docker cluster - customize static pods with binding annotations - code cleanup - removed hacky podtask.And func; support minimal resources for static pods when resource accounting is disabled - removed zip archive of static pods, changed to gzip of PodList json - pod utilities moved to package podutil - added e2e test - merge watched mirror pods into the mesos pod config stream

googlebot · 2015-11-13T23:30:51Z

CLAs look good, thanks!

k8s-bot · 2015-11-13T23:50:52Z

GCE e2e build/test failed for commit f8517c2067632f979296ba106ed13ab8e5c03055.

k8s-bot · 2015-11-13T23:50:52Z

GCE e2e build/test failed for commit 3d3577b.

jdef · 2015-11-16T15:36:27Z

@k8s-bot please test this

sttts · 2015-11-16T15:45:13Z

@k8s-bot test this please

k8s-bot · 2015-11-16T16:14:00Z

GCE e2e test build/test passed for commit 3d3577b.

sttts · 2015-11-16T16:17:35Z

contrib/mesos/pkg/executor/executor.go

-				Op:   kubetypes.UPDATE,
-				Pods: []*api.Pod{oldPod},
-			})
+			k.sendPodsSnapshot()


Can you add a comment that we send the first birth cry here with an empty pod list?

this is more like a death-cry. is your comment misplaced?

Oh right. Didn't see the context in the diff.

sttts · 2015-11-16T16:20:10Z

Small nit. Otherwise, looks good to me.

sttts · 2015-11-16T16:30:31Z

contrib/mesos/pkg/executor/executor.go

@@ -240,10 +251,7 @@ func (k *Executor) Registered(driver bindings.ExecutorDriver,
 	// emit an empty update to allow the mesos "source" to be marked as seen


here we have the birth cry 👍

k8s-github-robot · 2015-11-16T20:50:32Z

Continuous integration appears to have missed, closing and re-opening to trigger it

k8s-github-robot · 2015-11-16T21:11:19Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2015-11-16T21:48:13Z

GCE e2e test build/test passed for commit 3d3577b.

k8s-github-robot · 2015-11-16T21:53:22Z

Automatic merge from submit-queue

Auto commit by PR queue bot

jdef added kind/bug Categorizes issue or PR as related to a bug. area/platform/mesos team/mesosphere labels Sep 14, 2015

jdef self-assigned this Sep 14, 2015

googlebot added the cla: no label Sep 14, 2015

jdef reviewed Sep 14, 2015
View reviewed changes

k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 15, 2015

sttts deleted the static-pods branch September 16, 2015 07:14

jdef restored the static-pods branch September 16, 2015 18:09

jdef reviewed Sep 18, 2015
View reviewed changes

k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 18, 2015

sttts reviewed Sep 18, 2015
View reviewed changes

jdef force-pushed the static-pods branch from f8517c2 to 3d3577b Compare November 13, 2015 23:30

sttts reviewed Nov 16, 2015
View reviewed changes

jdef added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2015

k8s-github-robot closed this Nov 16, 2015

k8s-github-robot reopened this Nov 16, 2015

k8s-github-robot pushed a commit that referenced this pull request Nov 16, 2015

Merge pull request #13943 from mesosphere/static-pods

a999c0f

Auto commit by PR queue bot

k8s-github-robot merged commit a999c0f into kubernetes:master Nov 16, 2015

sttts pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Nov 17, 2015

Merge pull request kubernetes#13943 from mesosphere/static-pods

3af1fd1

Auto commit by PR queue bot

sttts deleted the static-pods branch November 18, 2015 10:29

sttts pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Nov 30, 2015

Merge pull request kubernetes#13943 from mesosphere/static-pods

552cf92

Auto commit by PR queue bot

s-urbaniak pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Dec 10, 2015

Merge pull request kubernetes#13943 from mesosphere/static-pods

f7720d8

Auto commit by PR queue bot

jdef pushed a commit to mesosphere-backup/kubernetes that referenced this pull request Jan 25, 2016

Merge pull request kubernetes#13943 from mesosphere/static-pods

94d84ce

Auto commit by PR queue bot

		@@ -240,10 +251,7 @@ func (k *Executor) Registered(driver bindings.ExecutorDriver,
		// emit an empty update to allow the mesos "source" to be marked as seen

MESOS: don't attempt to schedule static pods #13943

MESOS: don't attempt to schedule static pods #13943

Conversation

jdef commented Sep 14, 2015

googlebot commented Sep 14, 2015

jdef Sep 14, 2015

Choose a reason for hiding this comment

k8s-bot commented Sep 14, 2015

k8s-github-robot commented Sep 15, 2015

k8s-bot commented Sep 17, 2015

jdef commented Sep 17, 2015

sttts commented Sep 17, 2015

sttts commented Sep 17, 2015

jdef commented Sep 17, 2015

sttts commented Sep 17, 2015

jdef Sep 18, 2015

Choose a reason for hiding this comment

k8s-bot commented Sep 18, 2015

jdef commented Sep 18, 2015

k8s-bot commented Sep 18, 2015

k8s-github-robot commented Sep 18, 2015

sttts Sep 18, 2015

Choose a reason for hiding this comment

k8s-bot commented Nov 13, 2015

k8s-bot commented Nov 13, 2015

googlebot commented Nov 13, 2015

googlebot commented Nov 13, 2015

googlebot commented Nov 13, 2015

k8s-bot commented Nov 13, 2015

k8s-bot commented Nov 13, 2015

jdef commented Nov 16, 2015

sttts commented Nov 16, 2015

k8s-bot commented Nov 16, 2015

sttts Nov 16, 2015

Choose a reason for hiding this comment

jdef Nov 16, 2015

Choose a reason for hiding this comment

sttts Nov 16, 2015

Choose a reason for hiding this comment

sttts commented Nov 16, 2015

sttts Nov 16, 2015

Choose a reason for hiding this comment

k8s-github-robot commented Nov 16, 2015

k8s-github-robot commented Nov 16, 2015

k8s-bot commented Nov 16, 2015

k8s-github-robot commented Nov 16, 2015