Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

host flavor: fix copying for Debian #1811

Merged
merged 2 commits into from Nov 30, 2015
Merged

Conversation

alban
Copy link
Member

@alban alban commented Nov 30, 2015

Fixes #1809


This makes the host flavor work on Debian for me. Tested with systemd-228-2.

/cc @onlyjob

@krnowak
Copy link
Collaborator

krnowak commented Nov 30, 2015

Looks ok, but seems it does not fix the issue, right?

@alban
Copy link
Member Author

alban commented Nov 30, 2015

@krnowak It worked for me on Debian (tested in Vagrant). And make clean also worked for me. But it was not working for @onlyjob (see #1809 (comment)). And it breaks something on Arch, @iaguis is looking at this.

iaguis and others added 2 commits November 30, 2015 17:23
This makes the host flavor work on Debian for me. Tested with
systemd-228-2.

Fixes rkt#1809
@iaguis
Copy link
Member

iaguis commented Nov 30, 2015

It works for both @alban and me now. LGTM.

@alban
Copy link
Member Author

alban commented Nov 30, 2015

Updated to ec44009 with fixes for Arch.

  • works for me in Debian (tested in Vagrant with systemd-228).
  • works for Iago in Arch

@onlyjob: how did you test the patch? Do you cherry pick the commits on top of the 0.12.0 release, or do you take the branch as is? In the first case, you might need to delete the old stage1 with rkt image rm sha512-xxxxxx. I just filed #1813 for that.

alban added a commit that referenced this pull request Nov 30, 2015
@alban alban merged commit e45e880 into rkt:master Nov 30, 2015
@onlyjob
Copy link

onlyjob commented Nov 30, 2015

I applied patch on top of 0.12.0 and indeed the problem was due to already imported stage1 image that rkt did not update automatically. As advised in #1813 I've built with

--with-stage1-default-flavor=host
--with-stage1-default-name=host
--with-stage1-default-version=$(VER)

which fixed the problem. Thank you.

@krnowak
Copy link
Collaborator

krnowak commented Dec 1, 2015

@onlyjob: And that worked? That should not be possible. --with-stage1-default-flavor is conflicting with --with-stage1-default-name and --with-stage1-default-version, so the configure should bail out in this case.

@onlyjob
Copy link

onlyjob commented Dec 1, 2015

Yes, as far as I can tell it did work. Why would flavour (i.e. type of image) conflict with its name?

@krnowak
Copy link
Collaborator

krnowak commented Dec 1, 2015

@onlyjob: --with-stage1-default-flavor=host is basically a convenience shorthand of --with-stage1-default-name=coreos.com/rkt/stage1-host --with-stage1-default-version=<version from AC_INIT>. And these flags only tell rkt to search for this name and version of the stage1 image in the store. They do not affect how/which stage1 is actually built.

@onlyjob
Copy link

onlyjob commented Dec 1, 2015

I see... Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants