Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute the .d.ts-es #841

Closed
PanayotCankov opened this issue Sep 29, 2015 · 8 comments
Closed

Distribute the .d.ts-es #841

PanayotCankov opened this issue Sep 29, 2015 · 8 comments
Assignees
@ErjanGavalji
Labels
done feature severity: medium
Milestone
1.5

Comments

@PanayotCankov
Copy link
Contributor

For good TS experience within the {N} we have to ship .d.ts-es for modules (and optionally to generate .d.ts-es for native APIs). This is a feature that needs shipping since most of the tooling is there for us already.
@PanayotCankov PanayotCankov self-assigned this Sep 29, 2015
@PanayotCankov PanayotCankov added this to the 1.5 (Under Review) milestone Sep 29, 2015
@ligaz
Copy link
Contributor

ligaz commented Sep 29, 2015

Consider adding typings key in the package.json or index.d.ts. More info here.

@PanayotCankov
Copy link
Contributor Author

@ligaz 👍

@PanayotCankov PanayotCankov mentioned this issue Oct 7, 2015
Closed
@ErjanGavalji
Copy link
Contributor

With TypeScript 1.6 using the Typings folder out of the box, it would be good to have the TypeScript declarations in a separate package. Thus, d.ts files won't be embedded in the tns-core-modules package, which is pure executable javascript code only.

Separation of concerns FTW!

@guillaume-roy
Copy link

In the meantime, how and where can we get d.ts files ?

@ligaz
Copy link
Contributor

ligaz commented Nov 9, 2015

You can find them in the release pages of this repo. Look at the downloads section: https://github.com/NativeScript/NativeScript/releases/tag/v1.4.0

@hdeshev hdeshev added the ready for test TSC needs to test this and confirm against live production apps and automated test suites label Nov 10, 2015
@guillaume-roy
Copy link

Thanks

@vchimev vchimev added done and removed backlog ready for test TSC needs to test this and confirm against live production apps and automated test suites labels Nov 11, 2015
@vchimev
Copy link
Contributor

vchimev commented Nov 11, 2015

Starting with {N} 1.5, .d.ts files will be included in the tns-core-modules package.

@vchimev vchimev closed this as completed Nov 11, 2015
@lock
Copy link

lock bot commented Aug 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ErjanGavalji ErjanGavalji

Labels
done feature severity: medium
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
6 participants
@ligaz @hdeshev @ErjanGavalji @guillaume-roy @PanayotCankov @vchimev