Deprecates defaultRescoreWindowSize #13995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
added
>breaking
review
:Core/Infra/Transport API
colings86
changed the title
|
LGTM shouldn't we also document the deprecation on the REST layer? |
|
This only seems to be a thing for the Java API and doesn't seem to be something you set on the REST layer. Also, I just noticed that SearchRequestBuilder has a similar method that needs deprecating so will push a that change too |
|
LGTM. Sorry for the mess. |
The window size should be set on each rescorer individually. This method will be removed in 3.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The window size should be set on each rescorer individually. This method will be removed in 3.0