Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove threadpool type cached setting from documentation? #14294

Closed
ppf2 opened this issue Oct 27, 2015 · 6 comments
Closed

Remove threadpool type cached setting from documentation? #14294

ppf2 opened this issue Oct 27, 2015 · 6 comments
Labels
discuss >docs General docs changes

Comments

@ppf2
Copy link
Member

ppf2 commented Oct 27, 2015

We don't recommend changing the size of the thread pools, and certainly not recommend setting them to unbounded. Seems like documenting the configuration to modify our thread pools to cached without sufficient warnings will do more harm than good.

@ppf2 ppf2 added the >docs General docs changes label Oct 27, 2015
@jasontedor
Copy link
Member

I think that we should go further than merely removing it from the documentation, but actually forbidding any thread pool other than the generic thread pool of being of type "cached". The generic thread pool should remain as "cached" because operations that are submitted to this thread pool can not block nor be rejected; we remain very careful about which operations are submitted to this thread pool. I've opened #14336 to address.

@bleskes
Copy link
Contributor

bleskes commented Oct 28, 2015

I wonder if we should allow to configure the thread pools types at all these days. Might be the simplest to just remove the option and fix the defaults we have now.

On 28 okt. 2015 3:22 PM +0100, Jason Tedornotifications@github.com, wrote:

I think that we should go further than merely removing it from the documentation, but actually forbidding any thread pool other than the generic thread pool of being of type "cached". The generic thread pool should remain as "cached" because operations that are submitted to this thread pool can not block nor be rejected; we remain very careful about which operations are submitted to this thread pool. I've opened#14336(#14336 address.


Reply to this email directly orview it on GitHub(#14294 (comment)).

@jasontedor
Copy link
Member

I've added the discuss label to open up if we want to take this further than merely forbidding the cached thread pool type and actually forbidding changing any thread pool type.

@jpountz
Copy link
Contributor

jpountz commented Oct 29, 2015

+1 to not allow to configure threadpool types at all

@s1monw
Copy link
Contributor

s1monw commented Oct 29, 2015

+1

@jasontedor
Copy link
Member

I've closed #14336 in favor of #14367 which takes the original pull request further by forbidding the changing of the thread pool type for any thread pool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss >docs General docs changes
Projects
None yet
Development

No branches or pull requests

5 participants