New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove threadpool type cached setting from documentation? #14294
Comments
I think that we should go further than merely removing it from the documentation, but actually forbidding any thread pool other than the generic thread pool of being of type "cached". The generic thread pool should remain as "cached" because operations that are submitted to this thread pool can not block nor be rejected; we remain very careful about which operations are submitted to this thread pool. I've opened #14336 to address. |
I wonder if we should allow to configure the thread pools types at all these days. Might be the simplest to just remove the option and fix the defaults we have now. On 28 okt. 2015 3:22 PM +0100, Jason Tedornotifications@github.com, wrote:
|
I've added the discuss label to open up if we want to take this further than merely forbidding the |
+1 to not allow to configure threadpool types at all |
+1 |
We don't recommend changing the size of the thread pools, and certainly not recommend setting them to unbounded. Seems like documenting the configuration to modify our thread pools to cached without sufficient warnings will do more harm than good.
The text was updated successfully, but these errors were encountered: