Remove the experimental indices.fielddata.cache.expire #13173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Hmm @clintongormley is this safe to merge? Or we need more people to review this. |
|
@jpountz please can your review? |
|
|
||
| ==== `indices.fielddata.cache.expire` | ||
|
|
||
| The experimental feature `indices.fielddata.cache.expire` has been removed. |
There was a problem hiding this comment.
Can you also say that for indices that have this setting configured, it will now be ignored (as opposed to rejected)?
There was a problem hiding this comment.
Thanks @jpountz, updated.
|
Just left a minor comment about the documentation, otherwise LGTM. |
xuzha
force-pushed
the
remove-cache-expire
branch
from
f89ce00
to
f46e66e
Compare
|
LGTM. Please merge. :) |
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10781