New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Meteor 1.2 #16877
Add support for Meteor 1.2 #16877
Conversation
3621fc8
to
88ccbf3
Compare
CC: @splendido @dandv for review |
LGTM |
Thanks guys 😄 I'm guessing that you guys will also push out an Atmosphere update too based on your ship list? |
We're waiting to hear from MDG on an issue with the Atmosphere publish bot, then @splendido will be able to trigger a push (thanks!). |
Oh I see, cool. |
cc: @dandv |
Before we do that, looks like we might need to revisit this again because Wondering if for maximum compatibility we should do something like: if (api.addAssets) {
// Use api.addAssets
} else {
// Use api.addFiles with { isAsset: true }
} |
Oh yeah, it's |
If we don't wanna set |
Just ran |
Would this be just to let people use In version 4 it seems fonts won't be included anymore. See the output of |
They have.a ship list for 3.3.6 so I guess at least that will nees for both current meteor and 1.2+ |
Guys, here's a new PR now that Meteor 1.2 is out. |
Is this still relevant now that Meteor can use npm packages directly? |
This is a refactor to prepare for the upcoming Meteor 1.2 release as well as any preview versions up to that point.
The
{ isAsset: true }
is backwards compatible, it's just that once 1.2 comes around, it will be required for those kinds of files.See this issue for more details.