Clarify Bamboo.Endpoint's uniqueness #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each Bamboo instance must be simultaneously directly addressable by the Marathon server.
j1n6
pushed a commit
that referenced
this pull request
Oct 28, 2015
Clarify Bamboo.Endpoint's uniqueness
|
Thank you, any doc improvements are always appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes explicit that each Bamboo instance needs a unique Endpoint address.
We figured this out the hard way after setting the endpoint to a DNS name that round-robined all of the bamboo servers. Only one instance would ever receive an update from Marathon, and so the bamboo instances all end up out-of-sync.
Happy to swap in any other/better language-- but hopefully this will save folks from making the mistake we did.