Improve consistency of error handling #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't actually see the need to define a second error variable in either case. Both times, err will be nil when err1/err2 is written to, so just using err throughout would not cause any problems (and be a lot more idiomatic) |
|
You're right, I wasn't quite sure about that. Ok I'll make another proposal for that |
|
I've changed it. Could you take a look again? |
|
🍤 lgtm. @activars? |
|
lgtm, I do have a branch that refactored this as well. I'm happy to merge this now. |
j1n6
pushed a commit
that referenced
this pull request
Oct 13, 2015
Improve consistency of error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've found another thing, maybe this make sense.
In api/service there some inconsistency to errors. Create function the second error called err2 but in the Put function it's err1. I guess it makes sense to name them both err2.
I'm also wondering why in Create responseError doesn't return the error from errors like in Put or All.