Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use marathon basic auth creds if available #162

Merged
merged 2 commits into from Sep 27, 2015
Merged

Use marathon basic auth creds if available #162

merged 2 commits into from Sep 27, 2015

Conversation

jdubs
Copy link
Contributor

@jdubs jdubs commented Sep 9, 2015

When calling a marathon instance and username and password are set, send them as basic auth.

@jdubs jdubs mentioned this pull request Sep 9, 2015
Closed
@lclarkmichalek
Copy link
Contributor

Could you run a go fmt ./... on this? Otherwise, looks good; I assume it fixes the #161 problem?

@jdubs
Copy link
Contributor Author

jdubs commented Sep 10, 2015

Derp! Sorry about that. All fixed up.

@bateau84
Copy link
Contributor

+1 (?)

j1n6 pushed a commit that referenced this pull request Sep 27, 2015
Merge pull request #162 from jdubs/marathon_basic_auth
417f442 
Use marathon basic auth creds if available
@j1n6 j1n6 merged commit 417f442 into QubitProducts:master Sep 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jdubs @lclarkmichalek @bateau84 @j1n6