Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload rework #160

Merged
merged 7 commits into from Sep 8, 2015
Merged

Reload rework #160

merged 7 commits into from Sep 8, 2015

Conversation

lclarkmichalek
Copy link
Contributor

Reworks most of the HAProxy reloading code to be a little more testable (and adds tests), while keeping the logic mostly identical. Also adds the features in #158.

The major affect of all this is that

  • We no longer exit if there is a problem trying to reload the haproxy config
  • We have better logging in the area
    • The names of the statsd metrics were changed (well, I added a 2 and changed 1)
  • We have a nice reliable way to test and cleanup config reloads.

Checklist:

  • Test
  • Document
  • Test on staging cluster for a while

@j1n6
Copy link
Contributor

j1n6 commented Sep 4, 2015

Do you mind squash the commits to sensible group?

  • Update README.md
  • Update example/dev config

@lclarkmichalek
Copy link
Contributor Author

Done

@j1n6
Copy link
Contributor

j1n6 commented Sep 4, 2015

looks good 👍 let's test on staging before release.

@lclarkmichalek
Copy link
Contributor Author

Seems hunky dory on staging. Merging and deploying.

@lclarkmichalek lclarkmichalek merged commit 6b20ee4 into master Sep 8, 2015
@lclarkmichalek lclarkmichalek deleted the reload_rework branch September 8, 2015 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants