Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored exception reporting of most operators. #3183

Merged
merged 1 commit into from Aug 28, 2015
Merged

Refactored exception reporting of most operators. #3183

merged 1 commit into from Aug 28, 2015
+167 −141

Conversation

akarnokd
Copy link
Member

Added two convenient methods to Exceptions which either throws a fatal exception or reports it with our without the causing value to an Observer.

@benjchristensen benjchristensen modified the milestone: 1.0.x Aug 28, 2015
@stealthcode
Copy link

👍

@stealthcode
Copy link

What if the Exceptions.throwOrReport(...) took a Subscriber instead? This way we could check if the downstream subscriber is unsubscribed and then if we are reporting we would instead log to the RxJavaPlugins.getInstance().getErrorHandler().handleError(e). This would standardize usage of the error handler plugin. Thoughts?

@akarnokd
Copy link
Member Author

@stealthcode Your suggestion can be applied after the merge with another PR if you wish.

@stealthcode
Copy link

I agree. Just suggesting for your input.

stealthcode pushed a commit that referenced this pull request Aug 28, 2015
Merge pull request #3183 from akarnokd/ThrowIfFatalSweep
a8ac1b0 
Refactored exception reporting of most operators.
@stealthcode stealthcode merged commit a8ac1b0 into ReactiveX:1.x Aug 28, 2015
@stealthcode stealthcode mentioned this pull request Aug 28, 2015
Closed
@akarnokd akarnokd mentioned this pull request Sep 3, 2015
Closed
@akarnokd akarnokd deleted the ThrowIfFatalSweep branch September 9, 2015 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Enhancement
Projects
None yet
Milestone
1.0.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akarnokd @stealthcode @benjchristensen