Lint fixes for unnecessary unboxing #3369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -57,9 +57,9 @@ public String toString() { | |||
| @Override | |||
| public int compare(TimedAction action1, TimedAction action2) { | |||
| if (action1.time == action2.time) { | |||
| return Long.valueOf(action1.count).compareTo(Long.valueOf(action2.count)); | |||
| return Long.valueOf(action1.count).compareTo(action2.count); | |||
There was a problem hiding this comment.
Could you turn these into a < b ? -1 : ((a > b) ? 1 : 0) instead?
There was a problem hiding this comment.
To avoid misunderstanding, don't use Long.compare() because we need to be Java 6 compatible and that method is not available in it.
|
See the comment, otherwise 👍. |
|
+1 for @akarnokd comment, otherwise 👍 |
|
@akarnokd @stevegury used ternaries in-place of |
|
👍 |
1 similar comment
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Sep 22, 2015
Lint fixes for unnecessary unboxing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Believe I'm removing some unnecessary unboxing calls, but please correct me if I'm wrong.