DoOnEach: report both original exception and callback exception. #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up in a [Stackoverflow](http://stackoverflow.com/questions/32889008/do-operators-instead-of-a-whole-subscriber) answer. If the doOnError's callback or the doOnEach's onError method throws, any non-fatal exception replaced the original error which got lost. This PR will wrap them both into a CompositeException. 2.x note: since Java 8 supports `addSuppressed` all callbacks in this situation either attach to the original exception or the original exception is attached to the callback's exception.
|
👍 |
abersnaze
added a commit
that referenced
this pull request
Oct 7, 2015
DoOnEach: report both original exception and callback exception.
|
Is there a way to avoid this wrapping? |
|
No, but you can unwrap via onErrorResumeNext: source.doOnError(e -> { throw new RuntimeException(); })
.onErrorResumeNext(e -> {
if (e instanceof CompositeException) {
return Observable.error(((CompositeException)e).getExceptions().get(1));
}
return Observable.error(e);
}); |
|
@akarnokd -- ah, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in a Stackoverflow answer. If the
doOnError's callback or thedoOnEach'sonErrormethod throws, any non-fatal exception replaced the original error which got lost. This PR will wrap them both into aCompositeException.2.x note: since Java 8 supports
addSuppressedall callbacks in this situation either attach to the original exception or the original exception is attached to the callback's exception.