Blocking subscribe methods for convenience #3174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| * Runs the source observable to a terminal event, ignoring any values and rethrowing any exception. | ||
| */ | ||
| @Experimental | ||
| public void run() { |
There was a problem hiding this comment.
can this be renamed to subscribe()?
There was a problem hiding this comment.
There is already a method named subscribe(). I've put in this alias for discoverability.
akarnokd
force-pushed
the
BlockingSubscribe
branch
from
2c915ad
to
3c045c7
Compare
|
Done. |
abersnaze
added a commit
that referenced
this pull request
Oct 8, 2015
Blocking subscribe methods for convenience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring some
Observable.subscribemethods onBlockingObservable.Related discussion: #3063.