Renaming Observable#x to Observable#extend #3423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
stealthcode
pushed a commit
that referenced
this pull request
Oct 8, 2015
Renaming Observable#x to Observable#extend
|
Correct me if I'm wrong but the merge policy requires two non-author likes, right? |
|
I thought it was two committers and if the auth was a committer that opening the PR was an implicit vote. I'll post some by laws so we can all agree on what the rules are. |
|
That was my understanding as well. I thought it was the releases that required more votes. |
|
Oh, I see. Checking my PRs again... |
hyleung
added a commit
to hyleung/ratpack
that referenced
this pull request
Apr 2, 2016
- Bump to RxJava 1.1.2 because Hystrix 1.5.1 depends on 1.1.1 - Changes expected behaviour in `RxErrorHandlingSpec` - exceptions thrown `onComplete` do not get propagated to `onError`. Related to this change in RxJava (ReactiveX/RxJava#3155), onComplete *must* return normally. - Code snippets in `RxRatpack.java` updated due to `Observable.x` being renamed `Observable.extend` - ReactiveX/RxJava#3423
hyleung
added a commit
to hyleung/ratpack
that referenced
this pull request
Apr 3, 2016
- Bump to RxJava 1.1.2. Upgrading to 1.1.1, saw test failures in `HystrixRequestCachingSpec` due to `ClassCastException`. I _think_ it may be related to a bug that was fixed in 1.1.2 (ReactiveX/RxJava#3697). - Changes expected behaviour in `RxErrorHandlingSpec` - exceptions thrown `onComplete` do not get propagated to `onError`. Related to this change in RxJava (ReactiveX/RxJava#3155), onComplete *must* return normally. This change went was included in RxJava 1.0.15. - Code snippets in `RxRatpack.java` updated due to `Observable.x` being renamed `Observable.extend` - ReactiveX/RxJava#3423. Also part of RxJava 1.0.15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.