Add Single.fromCallable() #3418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 I'm not too keen on reusing but the most complicated operators for |
| * the type of the item emitted by the {@link Single}. | ||
| * @return a {@link Single} whose {@link Observer}s' subscriptions trigger an invocation of the given function. | ||
| */ | ||
| public static <T> Single<T> fromCallable(final Callable<? extends T> func) { |
There was a problem hiding this comment.
This should start out as experimental unless the RxJava contributors want to fast-track this.
There was a problem hiding this comment.
Added @Experimental
artem-zinnatullin
force-pushed
the
single-from-callable
branch
from
ec5a160
to
c749075
Compare
|
@artem-zinnatullin rebase please. |
artem-zinnatullin
force-pushed
the
single-from-callable
branch
from
c749075
to
0ae074c
Compare
artem-zinnatullin
force-pushed
the
single-from-callable
branch
from
0ae074c
to
f64233f
Compare
|
@abersnaze rebased, I'll rebase one PR at a time, since they're all conflict with each other. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #3154.
@akarnokd I'd like to reuse
Observable.fromCallable()but didn't find apropriate way to do it:Observable.fromCallable().toSingle()is not best option, if you have some thoughts on this — please share them.