[#4284] Forward decoded messages more frequently #4322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Scottmitch PTAL. @ninja- this should help you... |
|
@normanmaurer looks good to me |
|
very creative way to keep the full API :P |
| for (int i = 0; i < size; i++) { | ||
| ctx.fireChannelRead(out.get(i)); | ||
| } | ||
| fireChannelRead(ctx, out, size); |
|
@normanmaurer - Few questions. Lookin good. |
normanmaurer
force-pushed
the
fire_on_each_decode
branch
from
c41d044
to
350128e
Compare
|
@Scottmitch comments addressed |
Motivation: At the moment we only forward decoded messages that were added the out List once the full decode loop was completed. This has the affect that resources may not be released as fast as possible and as an application may incounter higher latency if the user triggeres a writeAndFlush(...) as a result of the decoded messages. Modifications: - forward decoded messages after each decode call Result: Forwarding decoded messages through the pipeline in a more eager fashion.
normanmaurer
force-pushed
the
fire_on_each_decode
branch
from
350128e
to
0f7943c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
At the moment we only forward decoded messages that were added the out List once the full decode loop was completed. This has the affect that resources may not be released as fast as possible and as an application may incounter higher latency if the user triggeres a writeAndFlush(...) as a result of the decoded messages.
Modifications:
Result:
Forwarding decoded messages through the pipeline in a more eager fashion.