New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable incremental regeneration by default in Jekyll 3.0 #4059
Conversation
Disable the feature as it's still not 100% working 100% of the time. Feature can be re-enabled by specifying `full_rebuild: false` in the configuration
Need to update |
Is there any documentation on this feature? Perhaps it can say it's off by default. |
On it! There's barely any documentation, though it prints out whether it's enabled when building:
|
Maybe we should change this to say |
I prefer a switch/command/trigger to enable regeneration in general regardless of current state. Building, Serving, Regenerating... all specific and chosen capabilities. I would expect I would expect to $.02 💸 |
@jaybe-jekyll that very well could be the case when it's enabled by default but with it being disabled by default as an experimental feature now, that won't work. |
@jaybe-jekyll It's still very experimental, but that's a fantastic idea for the future! :) Especially because |
Agreed! Commits coming as soon as the tests pass. It'll be |
I need to correct myself; apologies -- I prefer a switch/command/trigger required to enable regeneration, Building, Serving, Regenerating... all specific and chosen capabilities. I would expect I would expect to Pfew. $.02 💸 |
I think |
@parkr: Would you prefer @jaybe-jekyll Not sure about the "flag presumes |
Another opinion; I think the term, "incremental", in "incremental regeneration" (i.e. --ir) applies more to a technical audience and isn't necessarily necessary or appropriate for general use(rs). Regenerate. Agreed; single character enablement; perhaps |
Historically, I have used |
@alfredxing I don't see how generation could occur within a system without --watch; does it not imply watching for changes ( |
@parkr @alfredxing: @jaybe-jekyll brings up a fine point, why not call the flag |
Does the |
@jaybe-jekyll Yeah, it's more about caching. |
Sass by default caches so they have a |
@alfredxing just waiting on this PR. once it's merged, i'll release an RC and then do any final bug fixes before I release around 8pm PST tonight. |
Sure! Right now I have it as |
|
Rename from `full_rebuild` to disable, to `incremental` to enable
Looks great! Thanks so much, @alfredxing. I'll merge once it's 💚 . |
👍 Good luck (& congrats!) on the launch tonight! |
@alfredxing Congrats to you, too! It's been a huge team effort. Thanks for all your time and effort thus far – it's meant a lot! |
Disable the feature as it's still not 100% working 100% of the time. Incremental regeneration can be re-enabled by specifying
full_rebuild: false
in the configuration.(As per discussion in #4057)