Sunset Maruku #3655
Merged
Sunset Maruku #3655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmph. Seems to be an issue with Minitest 5.6.0, which was released today. They messed around with Expectation or something. |
|
@alfredxing Thanks so much Alfred!!!!!! 🎉 Hope exams are going well. Feel free to rebase on latest master – it now has the locked minitest version. 😄 |
alfredxing
force-pushed
the
sunset-maruku
branch
from
a938431
to
5a60adb
Compare
|
Rebased and tests passing! |
parkr
added a commit
that referenced
this pull request
Apr 14, 2015
|
Terrific!!! Thank you 💓 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes Maruku from the
Gemfile, removes all references, and removes all Maruku-specific tests.Also displays the following when
markdown: marukuis still specified:Let me know if I missed anything!
Addresses #3098.