New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for Ruby 1.9.3. #3235
Conversation
@jekyll/core: Any objections? |
I'm okay with this. It seems like Liquid will only be dropping support for 1.9 in version 4 though (not version 3), unless something changed that I didn't catch in the issues archive. |
Yeah, it won't be officially dropped until v4. Liquid-C only works on Ruby 2+ though, so if you drop 1.9 it simplifies the upgrade path. |
If liquid v3 supports 1.9, then we should as well. 1.9.3 support should still be relatively easy to maintain and 1.9 still has a lot of legs in more enterprisey type places. My vote is to keep 1.9 support. On Thu, Dec 25, 2014 at 7:15 PM, Justin Li notifications@github.com
|
If we are headed towards Jekyll 3 then we should infact drop 1.9.3 in Jekyll 3 regardless of Liquid because to support it any longer prevents us from taking advantage of 2.2 while allowing 2.1 which has most of the features we would want minus the niceties that we should probably take advantage of. Leaving around old cruft prevents things like symbol GC, kwargs and a few other things that would be dearly beneficial in self documenting code (not so much the GC but kwargs.) |
We aren't the only project considering dropping any support for anything below 2.1 either, but we are the only ones who might have a major release this year. Thought I would throw that in as well. On top of: https://www.ruby-lang.org/en/news/2014/01/10/ruby-1-9-3-will-end-on-2015/ -- I know people will always fight for support to remain in Jekyll but that just hinders us and doesn't benefit the plenty because the few want us to remain agnostic and support old versions of Ruby. |
👍 with @envygeeks |
Considering the above, I'm ok with dropping support for 1.9.x but I'm not |
Thanks guys. We'll keep 2.0 for now. |
This is required by Liquid 3, and, hey, it's time to move on. It may continue to work, but we can't promise that will continue.