build/ops: ceph.spec.in: 50-rbd.rules conditional is wrong #5207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smithfarm please ignore the bot false negative, it will be fixed by #5208 |
|
@smithfarm the fix was merged, could you please rebase & repush to trigger the bot once more ? |
The conditionals governing where 50-rbd.rules is installed were not doing the right thing on SUSE distros. Start using the %_udevrulesdir RPM macro, while taking care that it is defined and set to the right value. Use it to eliminate some conditionals around other udev rules files as well. http://tracker.ceph.com/issues/12166 Fixes: ceph#12166 Signed-off-by: Nathan Cutler <ncutler@suse.com> (cherry picked from commit 8aa758e) Conflicts: ceph.spec.in hammer does not yet have _with_systemd or ceph_daemon.py
smithfarm
force-pushed
the
wip-12267-hammer
branch
from
464f594
to
4eb58ad
Compare
|
Pass http://tracker.ceph.com/issues/12701#ceph-deploy http://tracker.ceph.com/issues/12701#upgrade (there are job failures but they are unrelated to packaging) |
ghost
pushed a commit
that referenced
this pull request
Aug 30, 2015
ceph.spec.in: 50-rbd.rules conditional is wrong Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit 
ghost
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12267