Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Setting the version to 1.0.0.0 makes dnu throw a FileNotFoundException #2390

Closed
dromanchenko opened this issue Aug 1, 2015 · 6 comments
Closed

Setting the version to 1.0.0.0 makes dnu throw a FileNotFoundException #2390

dromanchenko opened this issue Aug 1, 2015 · 6 comments
Assignees
@JunTaoLuo
Labels
3 - Done bug
Milestone
1.0.0-beta8

Comments

@dromanchenko
Copy link

I am getting this when setting the version to 1.0.0.0 in project.json:
...
Microsoft .NET Development Utility CLR-x86-1.0.0-beta6-12256
Copying to output path C:\Users\Dima\AppData\Local\Temp\PublishTemp
System.IO.FileNotFoundException: Could not find file 'D:\Projects\My\Test\src\TestProject\bin\Release\TestProject.1.0.0.nupkg'.

It seems dnu not picking up the last zero from the version number and trying to find *.1.0.0.nupkg instead of *.1.0.0.0.nupkg. Or... the nuget package should be created as *.1.0.0.nupkg instead
@Eilon
Copy link
Member

Eilon commented Aug 2, 2015

NuGet uses SemVer, which has only 3 segments: http://semver.org/

Having said that, there should be a proper error for this.

@borgdylan
Copy link

This is due to the new versioning code which requires the fourth number only if it is not zero. Set it to 1.0.0 instead and you will have no problems publishing etc.

@analogrelay
Copy link
Contributor

We should still be properly normalizing input. You should be able to type 1.0.0.0 in any input field (version number in project.json, dependencies, etc.) and we should normalize it to 1.0.0

@borgdylan
Copy link

Currently if I do not type 1.0.0 i get many issues on publish. i ended up normalizing them by hand as it was getting too tedious to publish apps.

@analogrelay
Copy link
Contributor

@troydai Hey look, more normalization issues :P

@glennc glennc added this to the 1.0.0-beta8 milestone Aug 10, 2015
@davidfowl
Copy link
Member

@glennc When does this need design?

JunTaoLuo added a commit that referenced this issue Aug 24, 2015
@JunTaoLuo
fix #2390 by using normalized version numbers during dnu publish
bb0bcae
JunTaoLuo added a commit that referenced this issue Aug 26, 2015
@JunTaoLuo
fix #2390 by using normalized version numbers during dnu publish
01b91ed
JunTaoLuo added a commit that referenced this issue Aug 26, 2015
@JunTaoLuo
fix #2390 by forcing SemanticVersion.toString() to normalize version
9e50514 
-removed references to OriginalString
-removed DnuRestore test for unnormalized directory on disk
-added DnuPack test for version normalization
-amending PR comments
JunTaoLuo added a commit that referenced this issue Aug 28, 2015
@JunTaoLuo
fix #2390 by using normalized version numbers during dnu publish
a297f5f
JunTaoLuo added a commit that referenced this issue Aug 28, 2015
@JunTaoLuo
fix #2390 by forcing SemanticVersion.toString() to normalize version
6bb2cce 
-removed references to OriginalString
-removed DnuRestore test for unnormalized directory on disk
-added DnuPack test for version normalization
-amending PR comments
JunTaoLuo added a commit that referenced this issue Aug 28, 2015
@JunTaoLuo
fixing #2390 with more normalization
41904dd
JunTaoLuo added a commit that referenced this issue Aug 28, 2015
@JunTaoLuo
fix #2390 by using normalized version numbers during dnu publish
226a158
JunTaoLuo added a commit that referenced this issue Aug 28, 2015
@JunTaoLuo
fix #2390 by forcing SemanticVersion.toString() to normalize version
69f4017 
-removed references to OriginalString
-removed DnuRestore test for unnormalized directory on disk
-added DnuPack test for version normalization
-amending PR comments
@analogrelay analogrelay mentioned this issue Sep 1, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta8
Development

No branches or pull requests
7 participants
@analogrelay @davidfowl @Eilon @glennc @dromanchenko @JunTaoLuo @borgdylan