Hello @dmagliola

Code looks good but need some improvements:

1. Rename NamespaceItem::getOriginalDisplayName -> NamespaceItem::getName
2. Modify signature of method TreeItem::childCount virtual uint childCount(bool recursive = false) const = 0;
3. Update signatures in child classes:
   3.1. DatabaseItem
   3.2. KeyItem
   3.3. NamespaceItem
   3.4. ServerItem
4. Remove NamespaceItem::descendantCount method and update NamespaceItem::childCount method:

 uint NamespaceItem::childCount(bool recursive) const
 {
    if (!recursive)
      return m_childItems.size();

    uint count = 0;
    for (auto item : m_childItems)
      count += item.childCount(true);

    return count;
 }

It will remove usage of RTTI and improve performance.

Please fix mentioned issues and I will merge this pull request. Thank you!

Thank you for reviewing this so quickly!
I like your changes, however, the childCount method doesn't work as you defined it, because childCount returns 0 for KeyItem, so the childCount is always 0 if recursive (you end up summing long strings of zeroes, basically). And if keyItem returns 1 on KeyItem::childCount, that pretty much destroys the tree.

It does work, however, if you define KeyItem::childCount, as such:

uint KeyItem::childCount(bool recursive) const
{
    return (uint) (recursive ? 1 : 0);
}

Although that's a bit weird... Of course that'd have a big comment explaining what you're doing, but it feels hacky.

Up to you, I have very little experience with Qt or the codebase, so you tell me how you'd prefer this.

@dmagliola Yes, I have missed this. But it's easy to solve this problem without any workarounds, just add virtual bool supportChildItems() { return true; } to TreeItem class, add virtual bool supportChildItems() { return false; } to KeyItem class and update code of NamespaceItem::childCount :

 uint NamespaceItem::childCount(bool recursive) const
 {
    if (!recursive)
      return m_childItems.size();

    uint count = 0;
    for (auto item : m_childItems) {
      if (item.supportChildItems()) {
        count += item.childCount(true);
      } else {
        count += 1;
      }
    }
    return count;
 }

In most cases it's better to extend interface instead of adding hardcode for concreate types.

I like that much more now! :-)
Done!
Let me know if that's ok

Merged! Thanks! Keep doing great improvements in RDM ;)

Thank you! My ability to do C++ and Qt is very, very limited, so not sure how much i'll be able to contribute, but I use RDM all day, and constantly come up with little tweaks and improbements, so now that I can actually compile, i'll try to implement them!
Thanks!

@dmagliola Large part of RDM is coded in JS/QML which is very easy to understand and modify (example is Value editor)
Also feel free to ping me via email or gitter if you need help or if you have any questions about codebase.