This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
rkt: Make run-prepared rerunnable when mds is missing #1436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a user has no metadata service running and runs rkt run-prepared without specifying mds-register=false, the pod is left in the run state and the user needs to reprepare the pod again to rerun. To avoid this scenario, this commit does an early check to see if the metadata service is available before the pod is moved to the run state. fixes rkt#1434
blixtra
force-pushed
the
blixtra/rkt-make-run-prepare-rerunnable
branch
from
fe59fbc
to
8f546de
Compare
|
LGTM, @eyakubovich @steveej this seem like a reasonable check? |
|
Good check. LGTM. |
jonboulle
added a commit
that referenced
this pull request
Sep 23, 2015
…runnable rkt: Make run-prepared rerunnable when mds is missing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user has no metadata service running and runs rkt run-prepared
without specifying mds-register=false, the pod is left in the run state
and the user needs to reprepare the pod again to rerun.
To avoid this scenario, this commit does an early check to see if the
metadata service is available before the pod is moved to the run state.
fixes #1434