This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
store: close aci.NewCompressedReader #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface for aci.NewCompressedReader changed in the upstream appc code (appc/spec#462) to return a ReadCloser instead of a Reader. Hence it's now our responsibility to close the returned ACI. Fixes rkt#1224
|
LGTM |
iaguis
added a commit
that referenced
this pull request
Sep 24, 2015
store: close aci.NewCompressedReader
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interface for aci.NewCompressedReader changed in the upstream appc
code (appc/spec#462) to return a ReadCloser
instead of a Reader. Hence it's now our responsibility to close the
returned ACI.
Fixes #1224
/cc @sgotti