This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1: pass supplementary Gids to diagexec #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iaguis
force-pushed
the
supplemental-groups
branch
from
468cde8
to
1261cf2
Compare
|
LGTM but please don't merge until we confirm in the spec. |
|
Oh actually, this is missing tests ;-) |
|
Started down this path @ jonboulle@5ef886e#diff-d0ed8ba011025e17583977c3e5d8a7bc |
|
I added the necessary support to actool with an eye towards getting the functional tests working |
iaguis
force-pushed
the
supplemental-groups
branch
from
1261cf2
to
b29808d
Compare
Thanks! It's not in 0.7.0 so we need to wait for the next spec release. |
iaguis
force-pushed
the
supplemental-groups
branch
from
b29808d
to
70dd2b1
Compare
| @@ -97,6 +101,15 @@ func init() { | |||
| globalFlagset.IntVar(&globalFlags.ServeHttpTimeout, "serve-http-timeout", 30, "HTTP Timeout to wait for a client connection") | |||
| } | |||
|
|
|||
| func in(list []int, el int) bool { | |||
There was a problem hiding this comment.
Wooo! Another implementation of in operator. I'll have to start adding some checks everytime I see it. :)
Disregard this comment. ;)
|
LFAD. |
iaguis
added a commit
that referenced
this pull request
Oct 6, 2015
stage1: pass supplementary Gids to diagexec
|
👏 awesome! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1309