Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compile error in utf8 unittest #4861

Closed
larkost opened this issue Sep 18, 2015 · 4 comments
Closed

compile error in utf8 unittest #4861

larkost opened this issue Sep 18, 2015 · 4 comments
Labels
Milestone

Comments

@larkost
Copy link
Collaborator

larkost commented Sep 18, 2015

I am getting an error while building the unittests from next. The server works as expected. The specific error is:

src/unittest/utf8.cc:573:124: error: expression with side effects has no effect in an unevaluated context [-Werror,-Wunevaluated-expression]
        switch (0) case 0: default: if (const ::testing::AssertionResult gtest_ar = (::testing::internal:: EqHelper<(sizeof(::testing::internal::IsNullLiteralHelper(*current++)) == 1)>::Compare("*current++", "*it++", *current++, *it++))) ; else return ::testing::internal::AssertHelper(::testing::TestPartResult::kFatalFailure, "src/unittest/utf8.cc", 573, gtest_ar.failure_message()) = ::testing::Message();

This is a little odd, since there has been no change in that file since August 10.

@danielmewes danielmewes added this to the 2.2 milestone Sep 18, 2015
@danielmewes
Copy link
Member

Which platform / compiler is this with?

@larkost
Copy link
Collaborator Author

larkost commented Sep 18, 2015

Sorry... meant to write that once my compile on newton finished. This happens reliably on my Mac, but I am not able to reproduce on gantz. There was just an Xcode update today which I did locally, which might account for it.

@larkost
Copy link
Collaborator Author

larkost commented Sep 23, 2015

I updated gantz to the lasted OS X version (10.10.5), and updated Xcode and that causes this problem there too. So it looks like that is what is going on here.

danielmewes pushed a commit that referenced this issue Sep 25, 2015
@danielmewes
Copy link
Member

Fixed in next 476d2e6 and also cherry-picked into v2.1.x with d6cad7a.

@danielmewes danielmewes modified the milestones: 2.1.x, 2.2, 2.1.5 Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants