[#4147] Allow to disable recycling #4157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trustin please check |
| private static final AtomicInteger ID_GENERATOR = new AtomicInteger(Integer.MIN_VALUE); | ||
| private static final int OWN_THREAD_ID = ID_GENERATOR.getAndIncrement(); | ||
| // TODO: Some arbitrary large number - should adjust as we get more production experience. | ||
| private static final int DEFAULT_INITIAL_MAX_CAPACITY = 262144; |
There was a problem hiding this comment.
Should we stick to this default value? /cc @normanmaurer @tea-dragon
There was a problem hiding this comment.
@trustin for now yes. Let us use a new pr if we want to adjust it
|
Could we log that recycler has been disabled explicitly? |
|
Just one trivial comment about logging. How about logging 'disabled' instead of '0' in the logging statement here? |
Motivation: Sometimes it is useful to disable recycling completely if memory constraints are very tight. Modifications: Allow to use -Dio.netty.recycler.maxCapacity.default=0 to disable recycling completely. Result: It's possible to disable recycling now.
normanmaurer
force-pushed
the
disable_recycle
branch
from
15834c7
to
ddbc5fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Sometimes it is useful to disable recycling completely if memory constraints are very tight.
Modifications:
Allow to use -Dio.netty.recycler.maxCapacity.default=0 to disable recycling completely.
Result:
It's possible to disable recycling now.