Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot support local repos with none-ASCII characters in path #336

Closed
lychichem opened this issue Aug 30, 2015 · 9 comments
Closed

Cannot support local repos with none-ASCII characters in path #336

lychichem opened this issue Aug 30, 2015 · 9 comments
Labels
bug

Comments

@lychichem
Copy link

For example, I have a repo which locates in "D:\Onedrive\文档\Github\Firefox-zh-CN-locale", there are Chinese characters in path, then git for Windows 2.5 cannot set it as a workspace. But in git for Windows 1.9.5 preview it CAN work properly. Hope you'll fix this problem.
@techstay
Copy link

我问题和你一样，目前只能先滚回了1.9……:sob:

@lychichem
Copy link
Author

@techstay 你应该养成所有路径名都使用英文的习惯
And hope you developers can fix it. I don't know how many people uses their locale language with none ASCII characters as repo path.

@linquize
Copy link

WinXP (Chinese) desktop folder is C:\Documents and Settings\User\桌面
If you put your work inside desktop, you cannot avoid path containing Chinese.

@lychichem
Copy link
Author

Right, and for Onedrive, in Chinese the document folder is called "文档“, like what I report.

@rikaunite
Copy link

Steps to reproduce the problem? Looks fine to me.

rikaunite@RIKAUNITE-LT MINGW64 ~
$ mkdir 测试

rikaunite@RIKAUNITE-LT MINGW64 ~
$ cd 测试

rikaunite@RIKAUNITE-LT MINGW64 ~/测试
$ git clone https://github.com/lychichem/Firefox-zh-CN-locale.git
Cloning into 'Firefox-zh-CN-locale'...
remote: Counting objects: 2655, done.
remote: Compressing objects: 100% (131/131), done.
remote: Total 2655 (delta 66), reused 0 (delta 0), pack-reused 2503
Receiving objects: 100% (2655/2655), 2.00 MiB | 819.00 KiB/s, done.
Resolving deltas: 100% (1421/1421), done.
Checking connectivity... done.

rikaunite@RIKAUNITE-LT MINGW64 ~/测试
$ cd Firefox-zh-CN-locale/

rikaunite@RIKAUNITE-LT MINGW64 ~/测试/Firefox-zh-CN-locale (master)
$ touch 测试

rikaunite@RIKAUNITE-LT MINGW64 ~/测试/Firefox-zh-CN-locale (master)
$ ls
README.md  browser/  chrome/  chrome.manifest  install.rdf  测试

rikaunite@RIKAUNITE-LT MINGW64 ~/测试/Firefox-zh-CN-locale (master)
$ git status
On branch master
Your branch is up-to-date with 'origin/master'.
Untracked files:
  (use "git add <file>..." to include in what will be committed)

        "\346\265\213\350\257\225"

nothing added to commit but untracked files present (use "git add" to track)

rikaunite@RIKAUNITE-LT MINGW64 ~/测试/Firefox-zh-CN-locale (master)
$ git add 测试

rikaunite@RIKAUNITE-LT MINGW64 ~/测试/Firefox-zh-CN-locale (master)
$ git commit -m 测试
[master 4425ebf] 测试
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 "\346\265\213\350\257\225"

rikaunite@RIKAUNITE-LT MINGW64 ~/测试/Firefox-zh-CN-locale (master)
$ git log -n 1
commit 4425ebfd61a2977fdeeab5c67d74a47bdcba4b43
Author: Your Name <you@example.com>
Date:   Sun Aug 30 13:11:32 2015 +0800

    测试

My system is Windows 10 English version with Chinese locale.

@lychichem
Copy link
Author

DId you ever try to use git GUI? Under git GUI if you open a work zone containing Chinese character in path it will throw a error report.

@rikaunite
Copy link

OK, looks like Git GUI read path with wrong encoding.
capture
Save "测试" as UTF-8:
capture0
Load with GB2312(Current system locale):
capture1

@linquize linquize mentioned this issue Aug 30, 2015
Closed
@dscho dscho mentioned this issue Sep 16, 2015
Closed
@dscho
Copy link
Member

dscho commented Sep 16, 2015

Hope you'll fix this problem.

Please note that throwing your problem my way, leaning back and munching peanuts is not exactly something I find highly motivating.

At least you could pretend that you are interested in participating actively in the resolution of this bug, it is an Open Source project, after all, not a paid-for product.

17 days are a long time. Long enough, certainly, to at least ask for advice how to start diagnosing one's own problem.

@dscho
Copy link
Member

dscho commented Sep 16, 2015

Everybody who has this problem should download msys-2.0.dll from https://github.com/dscho/msys2-runtime/releases/tag/home-non-ascii, replace the local file of the same name (it is in Git\usr\bin) and test.

@dscho dscho added the bug label Sep 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dscho @linquize @rikaunite @techstay @lychichem