Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropdown keypress event for comma key #3016

Closed
y9v opened this issue Sep 13, 2015 · 4 comments
Closed

Dropdown keypress event for comma key #3016

y9v opened this issue Sep 13, 2015 · 4 comments
Labels
Confirmed Bug
Milestone
2.1.4

Comments

@y9v
Copy link

y9v commented Sep 13, 2015

In many languages the key with keycode "188" (comma in en layout) is used for some letter. For example in russian language this key stands for letter "б".

Unfortunately, the semantic ui dropdown binds an event to this keycode, to separate tags (event for non multiselect fields), which makes typing the letter, assigned to this keycode impossible.

Is there some way to disable, or customize this functionality?
@jlukic jlukic added this to the 2.1.4 milestone Sep 13, 2015
jlukic added a commit that referenced this issue Sep 13, 2015
@jlukic
#3016, dont use delimiter key when not multiple with additions allowed
f86b801
@jlukic jlukic closed this as completed Sep 13, 2015
jlukic added a commit that referenced this issue Sep 13, 2015
@jlukic
#3016 release notes
052a961
jlukic added a commit that referenced this issue Sep 13, 2015
@jlukic
#3016 fix comma not delimiting correctly
fe7a246
@fentas
Copy link
Contributor

fentas commented Oct 31, 2015

Sorry to bring this up again.
I looked into the docs and source code. It seems that this functionality (comma separation) is hard coded.
Or is there a way to disable this? (Even better change it.)

@jlukic
Copy link
Member

jlukic commented Nov 1, 2015

There's a trick with current version, but its super ninja

$('.ui.dropdown').dropdown('internal', 'get shortcut keys', return {
    backspace  : 8,
    delimiter  : false,
    deleteKey  : 46,
    enter      : 13,
    escape     : 27,
    pageUp     : 33,
    pageDown   : 34,
    leftArrow  : 37,
    upArrow    : 38,
    rightArrow : 39,
    downArrow  : 40
  })
;

I just realized that I didn't actually solive this issue with the related commits, so I'll go ahead and re-open.

@jlukic jlukic reopened this Nov 1, 2015
jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic
Make shortcut key values a setting #3016
474cc73
jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic
Fixes #3016, adds setting for keys
300044e
@jlukic jlukic closed this as completed Nov 1, 2015
jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic
Make shortcut key values a setting #3016
4ca20c4
jlukic added a commit that referenced this issue Nov 1, 2015
@jlukic
Fixes #3016, adds setting for keys
7f3399c
@jlukic jlukic mentioned this issue Nov 7, 2015
Closed
@tsubaie
Copy link

tsubaie commented Dec 31, 2016

Dears,

I'm using version 2.2.6 and I still have the same bug.

@lubber-de

This comment was marked as spam.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Confirmed Bug
Projects
None yet
Milestone
2.1.4
Development

No branches or pull requests
5 participants
@jlukic @fentas @y9v @lubber-de @tsubaie