librbd: add valgrind memory checks for unit tests #5280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 54c8825)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 6ab1bb5)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit ed5472a)
The destructor wasn't waiting for all Finisher tasks to complete before stopping the thread. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 8e20240)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 8d87bdf)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 5534faa)
Also made small tweaks so that it can be compiled under a C++ compiler. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c44f8e7)
The C API functions were referencing the C++ CephContext instead of the C rados_config_t. Additionally, the ceph namespace was missing on the Formatter class. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 740fd27)
The bytes not in cache stat was potentially reading the bh length from a deleted bufferhead. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 5ccc442)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 2586e3b)
Should call the release function instead of deleting it to free librbd::RBD::AioCompletion and librbd::AioCompletion. Otherwise there is a potential memory leak. Signed-off-by: Zhiqiang Wang <zhiqiang.wang@intel.com> (cherry picked from commit ada7ec8)
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
… tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
… tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
… tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
… tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Jul 19, 2015
… tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
This was referenced Jul 20, 2015
ghost
self-assigned this
|
It went through a rbd suite ( http://tracker.ceph.com/issues/11990#rbd ). |
ghost
pushed a commit
that referenced
this pull request
Jul 28, 2015
librbd: add valgrind memory checks for unit tests Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/12384