Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: Log::reopen_log_file: take m_flush_mutex #5405

Merged
1 commit merged into from Aug 4, 2015
Merged

common: Log::reopen_log_file: take m_flush_mutex #5405

1 commit merged into from Aug 4, 2015

Conversation

liewegas
Copy link
Member

@athanatos @liewegas
Log::reopen_log_file: take m_flush_mutex
154f18c 
Otherwise, _flush() might continue to write to m_fd after it's closed.
This might cause log data to go to a data object if the filestore then
reuses the fd during that time.

Fixes: #12465
Backport: firefly, hammer
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 8778ab3)
@liewegas liewegas added this to the hammer milestone Jul 29, 2015
ghost pushed a commit that referenced this pull request Jul 29, 2015
@ldachary
Merge pull request #5405: Log::reopen_log_file: take m_flush_mutex
93a2bcd 
Reviewed-by:
@loic-bot
Copy link

SUCCESS: http://jenkins.ceph.dachary.org/job/ceph/6736/

@ghost ghost self-assigned this Aug 4, 2015
ghost pushed a commit that referenced this pull request Aug 4, 2015
Merge pull request #5405 from ceph/wip-12465-hammer
e801d4c 
Log::reopen_log_file: take m_flush_mutex

Reviewed-by: Loic Dachary <ldachary@redhat.com>
@ghost ghost merged commit e801d4c into hammer Aug 4, 2015
@ghost ghost changed the title Log::reopen_log_file: take m_flush_mutex common: Log::reopen_log_file: take m_flush_mutex Aug 4, 2015
@liewegas liewegas deleted the wip-12465-hammer branch November 23, 2016 20:11
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug-fix core
Projects
None yet
Milestone
hammer
3 participants
@liewegas @loic-bot @athanatos