Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies implementation #10789

Closed
3 tasks done
ogarbe opened this issue Aug 13, 2015 · 0 comments
Closed
3 tasks done

Cookies implementation #10789

ogarbe opened this issue Aug 13, 2015 · 0 comments

Comments

@ogarbe
Copy link
Contributor

ogarbe commented Aug 13, 2015

\Phalcon\Http\Response\Cookies implementation is wrong :

  • it's coupled with \Phalcon\Cookie object without possibility to use DI
  • get return a Cookie Object (would be better to have a CookieInterface)
  • \Phalcon\Cookie is coupled with Session without reason, if session is not started it will break
ogarbe pushed a commit to vpg/cphalcon that referenced this issue Aug 13, 2015
phalcon#10789 - Use DI to instantiate Cookie object
9341efa
ogarbe pushed a commit to vpg/cphalcon that referenced this issue Aug 13, 2015
phalcon#10789 - Use DI to instantiate Cookie object
5c821c4
ogarbe pushed a commit to vpg/cphalcon that referenced this issue Aug 13, 2015
phalcon#10789 - Check if session is started in Cookie handling
6d49131
ogarbe pushed a commit to vpg/cphalcon that referenced this issue Aug 13, 2015
phalcon#10789 - Add CookieInterface and use it
f752d0d
ogarbe pushed a commit to vpg/cphalcon that referenced this issue Aug 13, 2015
phalcon#10789 - Update Changelog
2644966
@ogarbe ogarbe mentioned this issue Aug 13, 2015
Merged
andresgutierrez added a commit that referenced this issue Aug 14, 2015
@andresgutierrez
Merge pull request #10792 from vpg/issue_10789
d69a8e2 
Cookie fix #10789
@itbdw itbdw mentioned this issue Jun 26, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andresgutierrez @ogarbe